Skip to content

Switch to new REST object APIs #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Conversation

mike-petrov
Copy link
Contributor

closes #114

Signed-off-by: Mikhail Petrov mike@nspcc.ru

@mike-petrov mike-petrov self-assigned this Aug 8, 2024
@mike-petrov
Copy link
Contributor Author

Few questions:

  1. Do we want to remove nginx configuration from the readme? (https://github.com/nspcc-dev/send-fs-neo-org#nginx-config-example-on-the-production-server)

  2. Loading objects locally still didn't work due to a container error: writer close: status: code = 2048 message = access to object operation denied, problem seems to be container permissions.

@mike-petrov
Copy link
Contributor Author

mike-petrov commented Aug 8, 2024

Regarding the 2 statement: in the production it works now: send.fs.neo.org, but if I use this container locally with rest, it shows: access to object operation denied, but I attach bearrer token in request header

Maybe it's domain specific and everything will work?

@roman-khimov
Copy link
Member

nginx config should be updated, we can keep it, send.fs.neo.org always used it. Container permissions should be sufficient, if it works with the old API it should work the same with the new one.

@mike-petrov mike-petrov force-pushed the feature/114-switch_to_new_rest_api branch 2 times, most recently from fb9fdec to 21a0d87 Compare August 8, 2024 13:17
@mike-petrov mike-petrov force-pushed the feature/114-switch_to_new_rest_api branch 2 times, most recently from 35b87bb to fc09f35 Compare August 8, 2024 15:57
@mike-petrov
Copy link
Contributor Author

multipart/form-data in process

@mike-petrov mike-petrov marked this pull request as draft August 9, 2024 16:08
@mike-petrov mike-petrov force-pushed the feature/114-switch_to_new_rest_api branch from efaea7e to 692fe1a Compare August 13, 2024 12:19
@mike-petrov mike-petrov marked this pull request as ready for review August 13, 2024 12:21
@mike-petrov
Copy link
Contributor Author

Everything's ready, but we're also waiting @532910 with updated nginx configuration to readme

@mike-petrov
Copy link
Contributor Author

@roman-khimov done

location /gate/upload/ {
rewrite ^/gate/(.*) /upload/$data_cid break;
proxy_pass https://$neofs_http_gateway;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%s/neofs_http_gateway/neofs_rest_gateway/g

Signed-off-by: Mikhail Petrov <mike@nspcc.ru>
Signed-off-by: Mikhail Petrov <mike@nspcc.ru>
Signed-off-by: Mikhail Petrov <mike@nspcc.ru>
@mike-petrov mike-petrov force-pushed the feature/114-switch_to_new_rest_api branch from 597a7d2 to bdeee79 Compare August 14, 2024 09:35
@mike-petrov mike-petrov requested a review from 532910 August 14, 2024 09:35
@532910 532910 merged commit c879f9d into master Aug 14, 2024
1 check passed
@532910 532910 deleted the feature/114-switch_to_new_rest_api branch August 14, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to new REST object APIs
3 participants